Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule card #1293

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Schedule card #1293

wants to merge 8 commits into from

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Jul 31, 2024

Closes #1273

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (91b145c) to head (eaecc82).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1293   +/-   ##
=======================================
  Coverage       12%     12%           
=======================================
  Files          264     264           
  Lines         7238    7238           
=======================================
  Hits           803     803           
  Misses        6435    6435

@DGoiana
Copy link
Collaborator Author

DGoiana commented Aug 2, 2024

thePeras
thePeras approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tooltip missing in the clock, but we can come back latter.
✅ 🛫

@thePeras
Copy link
Member

thePeras commented Aug 7, 2024

Also, for every text, we should assign a theme text style. This way we ensure consistent in the all app

@Process-ing
Copy link
Contributor

Just a little nitpick, shouldn't the dark card have a little gradient, like in the mockups?

@DGoiana DGoiana self-assigned this Nov 26, 2024
@DGoiana DGoiana changed the base branch from develop to ui/redesign December 3, 2024 13:01
@DGoiana DGoiana changed the base branch from ui/redesign to develop December 3, 2024 13:02
@DGoiana DGoiana requested a review from a team December 3, 2024 13:15
@thePeras thePeras requested a review from a team December 4, 2024 11:13
@DGoiana DGoiana requested a review from vitormpp December 9, 2024 22:07
vitormpp
vitormpp requested changes Dec 9, 2024
View reviewed changes
packages/uni_ui/lib/cards/schedule_card.dart
// final BadgeColors badgeColor;
final bool isActive;
final String? teacherName;
final String? teacherPhoto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teacherPhoto is not being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormpp vitormpp vitormpp requested changes

@thePeras thePeras thePeras approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@DGoiana DGoiana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schedule card
4 participants
@DGoiana @thePeras @Process-ing @vitormpp